Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Type attribute to Link of CSS #173

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

ffbeso
Copy link
Contributor

@ffbeso ffbeso commented Oct 11, 2023

Added this attribute because CSS was not applied correctly without it on e-reader devices (Checked on Kindle paperwhite 11th).

こちらのCLIと共通の修正です。
vivliostyle/vivliostyle-cli#448

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@akabekobeko akabekobeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
対応ありがとうございました!

@akabekobeko akabekobeko self-requested a review October 12, 2023 15:13
@akabekobeko
Copy link
Member

テスト コードの修正も必要なようです。

@ffbeso
Copy link
Contributor Author

ffbeso commented Oct 12, 2023

人生初PRなので、根本的なところが理解できてないところもありますが
testの全PASSを確認しました。

@akabekobeko akabekobeko merged commit 1015ed0 into vivliostyle:main Oct 12, 2023
2 checks passed
@akabekobeko
Copy link
Member

@ffbeso
テスト修正、ありがとうございました!
CI のテスト全パスを確認できたので Merge しました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants